[openstreetmap/openstreetmap-website] Arrange base layers menu in a grid (PR #3620)

Andy Allan notifications at github.com
Tue Jul 26 13:30:31 UTC 2022


I'm not going to argue the merits of one grid system against another - I'm not an expert in either! I'll note that bootstrap 5 has experimental support for CSS grids, that's disabled by default. Maybe that will become default in the future or we'll switch to it or something, I have no idea.

What I will say though is that we've spent a lot of time and effort getting rid of lots of our old custom CSS and using bootstrap instead. This brings unification to our style (e.g. no longer having arbitrary pixels everywhere), opens up the possibilities for easier customisation, and gives us free updates - the effort that goes into bootstrap far exceeds any effort we can put in to maintaining our own custom CSS, and the number of people familiar with bootstrap is far greater than the number of people familiar with our custom CSS.

I'm happy to still use custom CSS where it's necessary, but I really want to avoid it where there's an alternative.

In this case, we already have "grids of things that rearrange themselves based on screen size" elsewhere on the site, so it needs some pretty compelling reason to have this particular "grid of things" implemented entirely differently than the others.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3620#issuecomment-1195487268
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3620/c1195487268 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220726/4db67242/attachment.htm>


More information about the rails-dev mailing list