[openstreetmap/openstreetmap-website] Arrange base layers menu in a grid (PR #3620)

[Anton Khorev]

> > You _don't care which rows and columns they occupy_. Why would you go and write out those rows and columns if you don't care about them?
> 
> We've used https://getbootstrap.com/docs/5.1/layout/grid/#row-columns elsewhere on the site, which allows us to avoid being explicit, and also set different numbers of columns for different screen sizes.

But that way you still specify the number (and contents) of columns. But why would you care about the number of columns for layer buttons? Why not saying "however many columns possible as long as they are equal width and wider than this size"? That's what you can specify with one css property.

> > Is _not being based on screen size but being based on a container size_ a compelling reason?
> 
> It's a nice reason, but on its own isn't compelling - partly because the container size is based on screen size in this case.

And then you'll have this weird condition to check where on small screens the container is narrow, on wider screens it's wider and on yet wider screens it's narrow again.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3620#issuecomment-1195599406
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3620/c1195599406 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220726/d49e28a4/attachment.htm>