[openstreetmap/openstreetmap-website] Put layer selection buttons into bootstrap row to have two cols on smaller screens (PR #3629)

Anton Khorev notifications at github.com
Tue Jul 26 18:04:47 UTC 2022


"Politically correct" version of #3620 where instead of changing css we change javascript. Costs extra wrapper element for each button to utilize Bootstrap's gutters.

There's an assumption that small screens are not too small and are able to handle two buttons per row. Handling even smaller screens would require a custom breakpoint. Actually requiring two buttons per row is kind of backwards because we probably want the buttons themselves not to be too small, but this way we avoid providing widths values.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3629

-- Commit Summary --

  * Put layer selection buttons into bootstrap row to have two cols on smaller screens

-- File Changes --

    M app/assets/javascripts/leaflet.layers.js (6)
    M app/assets/stylesheets/common.scss (3)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3629.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3629.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3629
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3629 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220726/8028ac65/attachment.htm>


More information about the rails-dev mailing list