[openstreetmap/openstreetmap-website] Put layer selection buttons into bootstrap row to have two cols on smaller screens (PR #3629)

[Anton Khorev]

> When you're asked to make changes to a PR you can just push those changes to he same branch (force push if you're replacing the existing commits rather than adding to them) and it will change the PR rather than having to open a new one.

I don't want to push them to that branch. I opened this branch so you could compare the changes here and the changes there and pick the one that's better. And I don't think that this PR is better.

> Also adding snide comments really doesn't help - you have been doing good work and contributing useful changes but you've just set your reputation back several steps in my estimation.

You mean calling this a "politically correct version"? It is a version that is not technically better than the other one. It could be if we somehow get rid of most of css, then there would be one language less in use, but I don't think that's going to happen. Otherwise how is it easier to write presentational code in imperative languages all across the codebase, instead of writing in a declarative language in one place?

Or are you talking about "kind of backwards" about button widths? They have a label over them which is sourced from localized strings. This label might get larger than you expect. Is it still going to fit? You could have a minimal width specified and incerease it in case it doesn't work. But now instead I have to fix a number of columns to satisfy the *no specific widths* requirement. Now what if the width turns out to be insufficient? It's either custom css to make text smaller or custom breakpoints for smaller screen sizes to go back to the single-column layout.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3629#issuecomment-1195847225
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3629/c1195847225 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220726/69130ec3/attachment.htm>