[openstreetmap/openstreetmap-website] Update to iD v2.21.0 (PR #3561)

Martin Raifer notifications at github.com
Fri Jun 3 13:59:09 UTC 2022 

The following major changes required some adaptions of the iD integration code in this repo:
* Drop legacy support for Internet Explorer 11 ([#8811])
  * `Vendorfile` – use non-legacy source file for iD (which works in modern browsers, but not IE11)
* Use OAuth2 for authentication with OSM API ([#9134], thanks [@bhousel] and [@dakotabenjamin])
  * `CONFIGURE.md` & `config/settings.yml` – updated the installation instructions.
  * `app/assets/javascripts/edit/id.js.erb` & `app/views/site/_id.html.erb` – simplify the check whether iD is configured
  * `app/assets/javascripts/id.js` & `app/views/site/id.html.erb` – upgrade to OAuth 2 authentication
  * `test/controllers/site_controller_test.rb` – remove some unnecessary setup/cleanup code

:warning: existing deployments need to reconfigure the authentication for iD! For the main iD deployments on osm.org, I've created new OAuth 2 Client IDs: `Ee1wWJ6UlpERbF6BfTNOpwn0R8k_06mvMXdDUkeHMgw` (for api06.dev.osm.org) and `0tmNTmd0Jo1dQp4AUmMBLtGiD9YpMuXzHefitcuVStc` (for osm.org).

<hr>

Further changes from the [changelog](https://github.com/openstreetmap/iD/blob/release/CHANGELOG.md#2210):

#### :white_check_mark: Validation
* Handle indoor features like buildings when checking for crossing ways ([#8944])
#### :bug: Bugfixes
* Fix rendering of KeepRight issues ([#8963])
* Fix KeepRight warnings showing up as "Unknown" issues ([#8925])
* Fix <kbd>⌥</kbd><kbd>W</kbd> keyboard shortcut not working on MacOS in certain system languages / keyboard layouts (e.g. Spanish) ([#8905])
* Render closed ways tagged as `public_transport=platform`, `waterway=dam` or `highway=elevator` as areas ([#8985])
* Fix a bug which caused validations to not take effect in certain situations ([#9021], thanks [@mbrzakovic])
* Properly escape currently logged-in user's user name ([#9097], thanks [@jleedev])
#### :rocket: Presets
* Optimize order of values in dropdowns of `access` fields ([#8945])
* Use value of `vehicle` tag as placeholder value of `access` fields for `motor_vehicle` and `bicycle`
* Render `golf` features `tee`, `fairway`, `rough` and `green` in green color and using a grass pattern ([#8927])
* Tweak preset-matching to penalize non-searchable presets when matching OSM objects to presets
* Do not overwrite existing `*=no` tags by a preset's `addTags`
* Imply `access=no` in access field of `highway=construction` objects ([#9102])
* Don't show non-language tag-suffixes in multilingual name field ([#9124], thanks [@wcedmisten])
* Render horse riding centers like farmyards ([#9118])
* Support searching presets by their `aliases` ([#6139])
* Allow searching presets by their tag (`key=value`) ([#8869])
#### Other
* Redact more API tokens from custom imagery sources in changeset metadata tags ([#8976], thanks [@k-yle])
* New Bing imagery API key and limit tiles vintage API requests ([#9133], thanks [@mbrzakovic])
#### :hammer: Development
* Switch build system to [esbuild](https://esbuild.github.io/) for much faster builds ([#8774], thanks [@mbrzakovic] and [@bhousel])
* Upgrade dependencies: maki to `v7.1`, `fontawesome` to `v6.1`, `d3` to `v7.4`, `node-diff` to `v3.1`, `mocha` to `v9.2`, `svg-sprite` to `v1.5.4`, `marked` to `v4.0`, `temaki` to `v5.1`, `mapillary-js` to `v4.1`

[#6139]: https://github.com/openstreetmap/iD/issues/6139
[#8774]: https://github.com/openstreetmap/iD/pull/8774
[#8811]: https://github.com/openstreetmap/iD/issues/8811
[#8869]: https://github.com/openstreetmap/iD/issues/8869
[#8905]: https://github.com/openstreetmap/iD/issues/8905
[#8925]: https://github.com/openstreetmap/iD/issues/8925
[#8927]: https://github.com/openstreetmap/iD/issues/8927
[#8944]: https://github.com/openstreetmap/iD/issues/8944
[#8945]: https://github.com/openstreetmap/iD/issues/8945
[#8963]: https://github.com/openstreetmap/iD/issues/8963
[#8976]: https://github.com/openstreetmap/iD/issues/8976
[#8985]: https://github.com/openstreetmap/iD/issues/8985
[#9021]: https://github.com/openstreetmap/iD/pull/9021
[#9097]: https://github.com/openstreetmap/iD/pull/9097
[#9102]: https://github.com/openstreetmap/iD/issues/9102
[#9118]: https://github.com/openstreetmap/iD/issues/9118
[#9124]: https://github.com/openstreetmap/iD/pull/9124
[#9133]: https://github.com/openstreetmap/iD/pull/9133
[#9134]: https://github.com/openstreetmap/iD/pull/9134
[@wcedmisten]: https://github.com/wcedmisten
[@bhousel]: https://github.com/bhousel
[@dakotabenjamin]: https://github.com/dakotabenjamin
[@mbrzakovic]: https://github.com/mbrzakovic
[@jleedev]: https://github.com/jleedev
[@k-yle]: https://github.com/k-yle

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3561

-- Commit Summary --

  * Update to iD v2.21.0

-- File Changes --

    M CONFIGURE.md (32)
    M Vendorfile (2)
    M app/assets/javascripts/edit/id.js.erb (2)
    M app/assets/javascripts/id.js (9)
    M app/views/site/_id.html.erb (2)
    M app/views/site/id.html.erb (7)
    M config/settings.yml (2)
    M test/controllers/site_controller_test.rb (14)
    M vendor/assets/iD/iD.css.erb (46)
    M vendor/assets/iD/iD.js (198703)
    M vendor/assets/iD/iD/data/imagery.min.json (2)
    M vendor/assets/iD/iD/img/fa-sprite.svg (2)
    M vendor/assets/iD/iD/img/maki-sprite.svg (2)
    M vendor/assets/iD/iD/img/temaki-sprite.svg (2)
    M vendor/assets/iD/iD/locales/ar.min.json (2)
    M vendor/assets/iD/iD/locales/ast.min.json (2)
    M vendor/assets/iD/iD/locales/bg.min.json (2)
    M vendor/assets/iD/iD/locales/ca.min.json (2)
    M vendor/assets/iD/iD/locales/cs.min.json (2)
    M vendor/assets/iD/iD/locales/da.min.json (2)
    M vendor/assets/iD/iD/locales/de.min.json (2)
    M vendor/assets/iD/iD/locales/el.min.json (2)
    M vendor/assets/iD/iD/locales/en.min.json (2)
    M vendor/assets/iD/iD/locales/eo.min.json (2)
    M vendor/assets/iD/iD/locales/es.min.json (2)
    M vendor/assets/iD/iD/locales/et.min.json (2)
    M vendor/assets/iD/iD/locales/eu.min.json (2)
    M vendor/assets/iD/iD/locales/fa.min.json (2)
    M vendor/assets/iD/iD/locales/fi.min.json (2)
    M vendor/assets/iD/iD/locales/fr-FR.min.json (2)
    M vendor/assets/iD/iD/locales/fr.min.json (2)
    M vendor/assets/iD/iD/locales/gl.min.json (2)
    M vendor/assets/iD/iD/locales/he.min.json (2)
    M vendor/assets/iD/iD/locales/hi.min.json (2)
    M vendor/assets/iD/iD/locales/hr.min.json (2)
    M vendor/assets/iD/iD/locales/hu.min.json (2)
    M vendor/assets/iD/iD/locales/index.min.json (2)
    M vendor/assets/iD/iD/locales/is.min.json (2)
    M vendor/assets/iD/iD/locales/it.min.json (2)
    M vendor/assets/iD/iD/locales/ja.min.json (2)
    M vendor/assets/iD/iD/locales/km.min.json (2)
    M vendor/assets/iD/iD/locales/ko.min.json (2)
    M vendor/assets/iD/iD/locales/lt.min.json (2)
    M vendor/assets/iD/iD/locales/lv.min.json (2)
    M vendor/assets/iD/iD/locales/mk.min.json (2)
    M vendor/assets/iD/iD/locales/nl.min.json (2)
    M vendor/assets/iD/iD/locales/no.min.json (2)
    M vendor/assets/iD/iD/locales/pl.min.json (2)
    M vendor/assets/iD/iD/locales/pt-BR.min.json (2)
    M vendor/assets/iD/iD/locales/pt.min.json (2)
    M vendor/assets/iD/iD/locales/ru.min.json (2)
    M vendor/assets/iD/iD/locales/sk.min.json (2)
    M vendor/assets/iD/iD/locales/sr.min.json (2)
    M vendor/assets/iD/iD/locales/sv.min.json (2)
    M vendor/assets/iD/iD/locales/tr.min.json (2)
    M vendor/assets/iD/iD/locales/uk.min.json (2)
    M vendor/assets/iD/iD/locales/vi.min.json (2)
    M vendor/assets/iD/iD/locales/zh-CN.min.json (2)
    M vendor/assets/iD/iD/locales/zh-HK.min.json (2)
    M vendor/assets/iD/iD/locales/zh-TW.min.json (2)
    M vendor/assets/iD/iD/mapillary-js/mapillary.css (1)
    M vendor/assets/iD/iD/mapillary-js/mapillary.d.ts (1283)
    M vendor/assets/iD/iD/mapillary-js/mapillary.js (16)
    A vendor/assets/iD/iD/mapillary-js/mapillary.js.flow (8098)
    M vendor/assets/iD/iD/mapillary-js/mapillary.js.map (2)
    M vendor/assets/iD/iD/mapillary-js/mapillary.module.js (56554)
    A vendor/assets/iD/iD/mapillary-js/mapillary.module.js.flow (8098)
    M vendor/assets/iD/iD/mapillary-js/mapillary.module.js.map (2)
    M vendor/assets/iD/iD/mapillary-js/mapillary.unminified.js (52933)
    M vendor/assets/iD/iD/mapillary-js/mapillary.unminified.js.map (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3561.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3561.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3561
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3561 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220603/657cb4d5/attachment-0001.htm>

More information about the rails-dev mailing list