[openstreetmap/openstreetmap-website] Update to iD v2.21.0 (PR #3561)

[Martin Raifer]

@tyrasd commented on this pull request.



>  * Unless you have set up alternatives, use Name: "Local iD" and Main Application URL: "http://localhost:3000"
 * Check boxes for the following Permissions
-  * 'read their user preferences'
-  * 'modify the map'
-  * 'read their private GPS traces'
-  * 'modify notes'
-* Everything else can be left with the default blank values.
-* Click the "Register" button
-* On the next page, copy the "consumer key"
+  * 'Read user preferences'
+  * 'Modify user preferences'
+  * 'Modify the map'
+  * 'Read private GPS traces'
+  * 'Upload GPS traces'
+  * 'Modify notes'

In 2.21.0, iD requests the `write_prefs` scope (see https://github.com/openstreetmap/iD/blob/c79dfc601f794bab9d1fb7a27f00fd50d0d282c9/modules/services/osm.js#L23). AFAICS it is not (yet) used anywhere obvious. (//cc @bhousel: Did I overlooking something here?) I was however planning to make use of it in the not so far future to preserve some settings and/or editor states. That's why I choose to just keep it in.

`write_gpx` is currently not used by iD (and also not requested during authentication), but I thought about adding a functionality to upload traces from within iD at some point in the future.

I assumed that for a typical user setting up this repo, it would be less trouble to allow all potentially/eventually used permissions right now, as this would prevent hard to debug issues when the scopes would be used by iD at some point in the future.

Let me know if you prefer to handle it differently. I can also prepare a patch release which doesn't request `write_prefs`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3561#discussion_r892095457
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3561/review/999359064 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220608/39e000e6/attachment.htm>