[openstreetmap/openstreetmap-website] Wrap issue reports and comments in <div> instead of <p> (PR #3566)
Anton Khorev
notifications at github.com
Thu Jun 9 16:06:32 UTC 2022
Since the change to rich text in issues, their reports and comments contain block-level html elements. You can't put block-level elements inside a paragraph, this is invalid html. Rich text in other places like user diaries is wrapped in divs, it makes sense to do the same here.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/3566
-- Commit Summary --
* wrap issue report rich text in div
* Merge branch 'master' into issue-report-div
* Wrap issue comment rich text in div
* Merge branch 'master' into issue-report-div
-- File Changes --
M app/views/issues/_comments.html.erb (2)
M app/views/issues/_reports.html.erb (2)
M test/system/issues_test.rb (17)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/3566.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3566.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3566
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3566 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220609/f8cc8b1f/attachment.htm>
More information about the rails-dev
mailing list