[openstreetmap/openstreetmap-website] Margins for 'comment from' / 'reported by' lines on issues page (PR #3568)
Anton Khorev
notifications at github.com
Fri Jun 10 14:35:58 UTC 2022
Don't remove margins with `mb-0` class on reported-by lines.
After enabling markdown in issue reports/comments, they can consist of several paragraphs. There's spacing between paragraphs provided by their bottom margins. But then there's a reported-by line above and it doesn't have margins. This line is displayed next to the report text without any spacing which looks strange for multi-paragraph reports.
Before merging #3566 there was a kind-of margin provided by an empty paragraph resulting from invalid html. Now that paragraph is gone.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/3568
-- Commit Summary --
* Margins for 'comment from' / 'reported by' lines on issues page
-- File Changes --
M app/views/issues/_comments.html.erb (2)
M app/views/issues/_reports.html.erb (2)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/3568.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3568.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3568
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3568 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220610/2ac748f1/attachment.htm>
More information about the rails-dev
mailing list