[openstreetmap/openstreetmap-website] Remove redundant presence validation on belongs_to (PR #3482)

Andy Allan notifications at github.com
Tue Mar 1 10:13:01 UTC 2022


There's no need for us to have it when rails does this for us.

This is what I was trying to do when I found that #3470 needed doing first.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3482

-- Commit Summary --

  * Remove redundant presence validation on belongs_to

-- File Changes --

    M .rubocop_todo.yml (5)
    M app/models/changeset.rb (2)
    M app/models/changeset_comment.rb (4)
    M app/models/changeset_tag.rb (2)
    M app/models/issue_comment.rb (2)
    M app/models/message.rb (2)
    M app/models/node.rb (2)
    M app/models/node_tag.rb (2)
    M app/models/note_comment.rb (2)
    M app/models/old_node.rb (2)
    M app/models/old_node_tag.rb (2)
    M app/models/old_relation.rb (2)
    M app/models/old_relation_tag.rb (2)
    M app/models/old_way.rb (2)
    M app/models/old_way_tag.rb (2)
    M app/models/relation.rb (2)
    M app/models/relation_tag.rb (2)
    M app/models/report.rb (2)
    M app/models/trace.rb (2)
    M app/models/user_preference.rb (2)
    M app/models/way.rb (2)
    M app/models/way_tag.rb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3482.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3482.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3482
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3482 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220301/3a9e483f/attachment.htm>


More information about the rails-dev mailing list