[openstreetmap/openstreetmap-website] Viewing a changeset loses context of previous changeset list (#647)
Andy Allan
notifications at github.com
Tue Nov 1 10:44:15 UTC 2022
> It seems that "fixing" this involves an awful lot of complicated and fragile javascript
That's my feeling too. I wonder if there's a better approach that relies on less javascript, rather than more.
If the basic behaviour was that pagination worked properly without javascript, then we could use a small amount of javascript to enhance this (e.g. viewing more items without a full page reload). But what we have is javascript-only psuedo-pagination, and then we're looking at adding even more javascript to make it behave more like regular page loads. This seems the wrong strategy.
I also think adding more javascript that's changing urls, hooking into the browser page reloads etc, is either duplicating or will eventually conflict with [turbo](https://turbo.hotwired.dev/), which broadly covers this kind of functionality. I'm not saying we should use turbo to as part of the fix (although I'd happily review that) but what I want to avoid is making our lives harder in future.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/647#issuecomment-1298340289
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/issues/647/1298340289 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221101/5fa8ef08/attachment-0001.htm>
More information about the rails-dev
mailing list