[openstreetmap/openstreetmap-website] Pass original event instad of leaflet event to changeset bbox click simulation (PR #3798)

[Anton Khorev]

Later there's a call to jquery.simulate to simulate a click on a changeset link inside the sidebar. The purpose of using the jquery.simulate is, I guess, to pass the modifier keys to the new event. If you do ctrl+click there should be a ctrl+click event that is later handled as *open in a new tab*. Except this doesn't work when clicking changeset bboxes because their events are neither dom nor jquery ones. We need to get the original event to simulate it correctly.

After applying this fix, ctrl+clicks on bboxes should open changeset pages in new tabs.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3798

-- Commit Summary --

  * Pass original event instad of leaflet event to changeset bbox click simulation

-- File Changes --

    M app/assets/javascripts/index/history.js (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3798.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3798.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3798
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3798 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221116/8888a417/attachment.htm>