[openstreetmap/openstreetmap-website] Allow `user/preferences/[KEY]` to accept arbitrary keys (PR #3787)
Taylor Smock
notifications at github.com
Wed Nov 16 20:27:27 UTC 2022
Supporting `#` is easy -- the consumer just has to URL encode the key and then we have to URL decode. This is (effectively) what my patch currently does (it supports URL decoding). The sticking point has been multiple `.` in the URL (fixed by not having a `(.:format)` in the route, and I wasn't able to reproduce outside of our code base).
I do have a hack to allow for `.fmt` on this API call. It pretty much just checks the trailing characters for `.json` or `.xml` and then sets the return format. I don't like it, but I'll go ahead and push it.
I'm looking into better options, but something, somewhere, is causing issues when I do that. Which I'm trying to fix by stepping through the code.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3787#issuecomment-1317626338
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3787/c1317626338 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221116/aaef0819/attachment.htm>
More information about the rails-dev
mailing list