[openstreetmap/openstreetmap-website] Replace searching.gif images with Bootstrap spinners (PR #3779)

Andy Allan notifications at github.com
Thu Nov 17 13:00:35 UTC 2022


> Why should they be written outside of javascript?

Because there is html involved, and there are CSS style rules applied to that html. So if I want to make changes to that html, or the layout of where the spinner appears, or add an extra div or add padding or anything like that, then I should be looking in the `app/views` directory to find the html code and css classes.

We can by all means use JavaScript to implement the interactivity, but we shouldn't be using it for constructing html layouts or managing CSS classes.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3779#issuecomment-1318600407
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3779/c1318600407 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221117/ad4f8c37/attachment.htm>


More information about the rails-dev mailing list