[openstreetmap/openstreetmap-website] Fixes delimeter direction in map key (PR #3731)
bgo-eiu
notifications at github.com
Mon Oct 3 22:33:43 UTC 2022

This screenshot of the map key in Punjabi above shows the situation this PR is intebded to address, where "and" and opposite direction commas appear interspersed with the localized map key. This is because of the localized strings being joined with `to_sentence`, which is not aware of every locale and how to delimit a list for each one. Rather than asking all translators to translate "and" and provide a comma, this just uses either a left-to-right comma or a right-to-left comma depending on the known direction in order to keep things simple.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/3731
-- Commit Summary --
* Fixes delimeter direction in map key
-- File Changes --
M app/views/site/key.html.erb (13)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/3731.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3731.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3731
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3731 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221003/63d8cf68/attachment.htm>
More information about the rails-dev
mailing list