[openstreetmap/openstreetmap-website] Display icon for current note only if this icon is defined (PR #3746)

[Anton Khorev]

An alternative to displaying some other icon instead of the missing "hidden" icon. Don't display any icon for hidden and other unknown note states, only show a "halo" circle marker.

Previous version with "closed" icon: https://github.com/openstreetmap/openstreetmap-website/pull/3718#discussion_r981484149

Fixes https://github.com/openstreetmap/openstreetmap-website/issues/1215 - when you have note layer enabled you can click on other notes after hiding a note.

Fixes https://github.com/openstreetmap/openstreetmap-website/issues/546 - although this bug doesn't fully manifests itself in current website versions. Before the fix clicking "history" works, but it's a full page reload. What is supposed to happen is a partial reload of the sidebar.


You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3746

-- Commit Summary --

  * Display icon for current note only if this icon is defined

-- File Changes --

    M app/assets/javascripts/leaflet.map.js (12)
    M test/system/index_test.rb (19)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3746.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3746.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3746
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3746 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221008/cb58fe61/attachment-0001.htm>