[openstreetmap/openstreetmap-website] Add Communities page (#3301)
Adam Hoyle
notifications at github.com
Mon Oct 17 13:34:07 UTC 2022
@atomoil commented on this pull request.
> @@ -0,0 +1,17 @@
+<% content_for :heading do %>
+ <h1><%= t ".title" %></h1>
+<% end %>
+
+<p class="lead"><%= t ".lede_text" %></p>
+
+<h2><%= t ".local_chapters.title" %></h2>
+<p><%= t ".local_chapters.about_text" %></p>
+<p><%= t ".local_chapters.list_text" %></p>
+<ul>
+ <% @local_chapters.each do |chapter| %>
+ <li><a href="<%= chapter.url %>"><%= t "osm_community_index.communities.#{chapter.id}.name" %></a></li>
@gravitystorm ironically I put together some code to do this last night but ran out of time to test it. I’m not precious about it and more than happy to bin it in favour of something that is consistent with the rest of the site. Saying that - ideally any validation would not reject an entry with a missing/invalid URL, it would still list the chapter but with either a generic URL (eg the wiki page on local chapters) or no link (anchor tag).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3301#discussion_r997068688
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3301/review/1144172330 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221017/d5df89fe/attachment.htm>
More information about the rails-dev
mailing list