[openstreetmap/openstreetmap-website] Don't display error messages when second scheduled rc command fails (PR #3767)

[Tom Hughes]

@tomhughes commented on this pull request.



>          iframe.remove();
       }, 5000);
 
       iframe
         .hide()
         .appendTo("body")
-        .attr("src", url)
+        .attr("src", url) // Open url without having to worry about CORS because we never read the response. This is for editors like Potlatch that don't send Access-Control-Allow-Origin header.

This comment doesn't seem to have anything to do with this PR and also creates an extremely long line.

>        if (object && object.type === "note") {
         var noteQuery = { url: osmHost + OSM.apiUrl(object) };
-        sendRemoteEditCommand(remoteEditHost + "/import?" + Qs.stringify(noteQuery));
+        sendRemoteEditCommand(remoteEditHost + "/import?" + Qs.stringify(noteQuery), false); // This is an enhancement, don't display an error if it fails.

There's no need for the first part of this comment - the part after the comma is the only bit that is relevant. I'd also probably say `on failure` rather than `if it fails` because it avoids questions of what exactly `it` refers to.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3767#pullrequestreview-1155305757
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3767/review/1155305757 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221025/03e3c886/attachment.htm>