[openstreetmap/openstreetmap-website] Don't display error messages when second scheduled rc command fails (PR #3767)
Tom Hughes
notifications at github.com
Wed Oct 26 10:19:19 UTC 2022
@tomhughes commented on this pull request.
> iframe.remove();
}, 5000);
iframe
.hide()
.appendTo("body")
- .attr("src", url)
+ .attr("src", url) // Open url without having to worry about CORS because we never read the response. This is for editors like Potlatch that don't send Access-Control-Allow-Origin header.
Well if you really feel it's necessary, but as we're working to replace that code with XHR anyway I wouldn't bother.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3767#discussion_r1005496854
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3767/review/1156246101 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221026/cfbfb634/attachment.htm>
More information about the rails-dev
mailing list