[openstreetmap/openstreetmap-website] Have only one changeset link in chageset list, give it a Bootstrap button outline (PR #3775)

[Anton Khorev]

History pages have two links to every changeset: one from a comment and one form an id. Why? Maybe because there's a chance that user wrote a comment that is difficult to click, but there's no way to make an unclickable chageset id. However that's no longer relevant because the link is stretched to the entire box with the changeset info.

Second link is in the way of keyboard navigation. When tabbing through the changesets you get from the first link to the second one leading to the same place. On user's changesets page you have to press tab twice to get to the next changeset.

Here I removed the second link. Also I replaced the standard link outline that the comment has when it's keyboard-focused with a Bootstrap outline* for inputs covering the entire stretched link.

\* actually it's a box-shadow and I made it inset to keep it inside the comment box

![changeset-outline](https://user-images.githubusercontent.com/4158490/198832769-0d25c46b-091d-462e-bdba-5f2b64696595.png)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3775

-- Commit Summary --

  * Have only one changeset link in chageset list, give it a Bootstrap button outline

-- File Changes --

    M app/assets/stylesheets/common.scss (8)
    M app/views/changesets/_changeset.html.erb (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3775.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3775.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3775
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3775 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221029/840bcb45/attachment.htm>