[openstreetmap/openstreetmap-website] Remove query spinner show delay because the spinner is not hidden (PR #3776)
Anton Khorev
notifications at github.com
Sat Oct 29 16:47:10 UTC 2022
This is for "Query features" map tool. What was supposed to happen [here](https://github.com/openstreetmap/openstreetmap-website/commit/078059b76b8304368fd7ddac2dd563470e83472e#diff-8275a6df0995b2af17f0b52a0dfe5a00f8b09d9d51b89516e2612a3faa9d8c0fR127) is this I guess:
- the spinner is initially hidden
- when the query runs it's still hidden
- if the query runs longer than a second, the spinner is shown
The problem is that the spinner was never hidden. Therefore there's no point in having this delay timer.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/3776
-- Commit Summary --
* Remove query spinner show delay because the spinner is not hidden
-- File Changes --
M app/assets/javascripts/index/query.js (8)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/3776.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3776.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3776
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3776 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221029/3634e4aa/attachment.htm>
More information about the rails-dev
mailing list