[openstreetmap/openstreetmap-website] Replace searching.gif images with Bootstrap spinners (PR #3779)

[Anton Khorev]

https://getbootstrap.com/docs/5.1/components/spinners/

One problem with the current "loading" image is that it has a long url that may change:
https://www.openstreetmap.org/assets/searching-3343ef26a638a661762242d1f68b505ce78f59cf7a60d15a1ca81bd64da1166c.gif

This is inconvenient if I start caching html like I want to do in https://github.com/openstreetmap/openstreetmap-website/pull/3682. I have a [special fix](https://github.com/openstreetmap/openstreetmap-website/pull/3682/commits/2b5d1efa04db45f634a753fd29bc3a46ab8efe72) for this which I wouldn't need with Bootstrap spinners because they don't have any links to assets in their html.

Later I want to remove spinners from html templates and write them with javascript. It's already happening to various degrees in different places of the code.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3779

-- Commit Summary --

  * Replace spinners in html.erb templates
  * Replace spinners in javascript

-- File Changes --

    D app/assets/images/searching.gif (0)
    M app/assets/javascripts/osm.js.erb (2)
    M app/assets/javascripts/user.js (2)
    M app/assets/stylesheets/common.scss (24)
    M app/views/browse/query.html.erb (12)
    M app/views/changesets/history.html.erb (6)
    M app/views/changesets/index.html.erb (6)
    M app/views/geocoder/results.html.erb (8)
    M app/views/geocoder/search.html.erb (6)
    M app/views/layouts/_search.html.erb (8)
    M app/views/layouts/map.html.erb (6)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3779.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3779.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3779
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3779 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221031/fd9af50e/attachment-0001.htm>