[openstreetmap/openstreetmap-website] Text selection improvement for stretched links on history pages. (PR #3677)

[Anton Khorev]

There's one problem after merging #3675.

Let's suppose you're on a history page and you want to select the text of a changeset comment. It's a link so normally you'll hold Alt in addition to holding a button and moving your mouse. Except with Bootstrap stretched link it won't work because they implemented it with an ::after pseudo element inside the link that covers the link itself. Now you can only reach the pseudo element and not the text content.

But that's easily fixable by wrapping the text inside the link and lifting it above ::after.

I also made links for changeset ids so they can also be lifted above the pseudo element and be selectable while working as before when clicked.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3677

-- Commit Summary --

  * Put span inside stretched link to improve text selection
  * Make changeset id also a link so it can be displayed over the stretched link and be text-selectable
  * Simplify css for text selection with stretched link

-- File Changes --

    M app/assets/stylesheets/common.scss (4)
    M app/views/changesets/_changeset.html.erb (6)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3677.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3677.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3677
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3677 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220902/0df3e293/attachment.htm>