[openstreetmap/openstreetmap-website] Remember loaded changesets and scroll position in user edit history (PR #3682)

Anton Khorev notifications at github.com
Fri Sep 9 21:01:54 UTC 2022


This is:

- "Improve User Edit History" on DWG wishlist
- #647
- #1089

Is saves changeset list html pieces to sessionStorage and remembers scroll position. Going to a history page, clicking some link then pressing *back* (or *forward*) should bring back the viewed history state along with everything that was loaded by pressing *Load more*. Reloading the page by pressing *reload* button throws away cached data.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3682

-- Commit Summary --

  * Test restoring changeset list state
  * Save changeset lists into session storage
  * Load changeset lists from session storage
  * Merge changeset <ol>s on Load more
  * Update map after loading from session store
  * Save initial sidebar on history pages
  * Save/restore sidebar scroll position
  * Reload changesets on page refresh
  * Fix history sidebar not reappearing after close and restore from session storage
  * Use close button instead of geolink in sidebar content
  * Remove/readd loader img src because it might be volatile

-- File Changes --

    M app/assets/javascripts/index.js (56)
    M app/assets/javascripts/index/history.js (185)
    M app/assets/javascripts/router.js (46)
    M app/views/application/_sidebar_header.html.erb (2)
    A test/system/history_test.rb (99)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3682.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3682.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3682
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3682 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220909/ed2dbc65/attachment.htm>


More information about the rails-dev mailing list