[openstreetmap/openstreetmap-website] Combine small.scss into common.scss (PR #3689)

[Andy Allan]

We've moved away from the idea of having extra rules for small screens, and instead follow the bootstrap convention of designing for small screens first and overriding those rules if needed for larger screens.

Having a separate file remaining for a limited number of small screen rules is therefore counter-productive. Moving the remaining rules into common.scss, adjacent to the related rules for larger screen, makes the behaviour easier to understand, as well as making it easier to refactor the rules to a small-screen-first approach.

In addition, I changed a couple of media-width related things here too, moving to bootstrap utillities for the simple case of the registration page, and using a mixin to refactor how the breakpoint is stated for the main menu. I'd prefer to use only `media-breakpoint-up` but that can be left for the future.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3689

-- Commit Summary --

  * Combine small.scss into common.scss
  * Use bootstrap utility classes for showing the new user arm
  * Use bootstrap breakpoint mixin

-- File Changes --

    M app/assets/stylesheets/common.scss (125)
    M app/assets/stylesheets/screen-ltr.css (1)
    M app/assets/stylesheets/screen-rtl.css (1)
    D app/assets/stylesheets/small.scss (122)
    M app/views/users/new.html.erb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3689.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3689.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3689
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3689 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220914/e383a8c9/attachment-0001.htm>