[openstreetmap/openstreetmap-website] Vertically center about page icons with flex align-items (PR #3701)

Anton Khorev notifications at github.com
Mon Sep 19 08:56:59 UTC 2022


Icons on [the about page](https://www.openstreetmap.org/about) were shifted down too much because they were centered relative to headings with bottom margins. Also they were inside the headings which they shouldn't be, at least not as `<div>`s inside `<h2>`s.

Before:

![about-before](https://user-images.githubusercontent.com/4158490/190981984-1329c28e-fb31-4b66-a486-0d1ce41b33b9.png)

After:

![about-after](https://user-images.githubusercontent.com/4158490/190982034-fccb6049-6a34-4ff0-a87e-4ae3f02dfed0.png)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3701

-- Commit Summary --

  * Vertically center about page icons with flex align-items

-- File Changes --

    M app/assets/stylesheets/common.scss (2)
    A app/views/site/_about_section.html.erb (7)
    M app/views/site/about.html.erb (38)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3701.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3701.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3701
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3701 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220919/a41775e2/attachment.htm>


More information about the rails-dev mailing list