[openstreetmap/openstreetmap-website] Load notes with remote control (PR #3718)

Anton Khorev notifications at github.com
Wed Sep 28 20:57:52 UTC 2022


@AntonKhorev commented on this pull request.



> @@ -20,40 +19,41 @@ OSM.Note = function (map) {
       iconAnchor: [12, 40]
     })
   };
+  noteIcons.hidden = noteIcons.closed; // TODO replace with actual "hidden" icon when it's added

Do you want to hide notes from moderators too or do you want to keep this bug?
https://github.com/openstreetmap/openstreetmap-website/issues/546
https://github.com/openstreetmap/openstreetmap-website/issues/1215

I fixed it here to check if other things are working. Of course I can put it back if you want.

I'm using the "closed" icon because I assume that the actual "hidden" icon, like introduced here https://github.com/openstreetmap/openstreetmap-website/issues/507 , still doesn't exist.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3718#discussion_r982855793
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3718/review/1124349098 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220928/8f2f55e1/attachment.htm>


More information about the rails-dev mailing list