[openstreetmap/openstreetmap-website] Request wikidata and osm sophox to linkify some tag value (#2621)

[Kai Michael Poppe]

@kmpoppe commented on this pull request.



> +    url = if value =~ %r{^https?://}
+            value
+          else
+            TAG2LINK[key].gsub("$1", value)
+          end

In the not-so-unlikely-case that a mapper puts multiple values in there, wouldn't it be sensible to just display the value if it contains a semicolon?
Because a link to `facebook com / value1;value2` would almost certainly not yield an usable result either, would it?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2621#pullrequestreview-1376939971
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/2621/review/1376939971 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230409/33d2f409/attachment.htm>