[openstreetmap/openstreetmap-website] Use Bootstrap highlight class in note tables (PR #4150)

Tom Hughes notifications at github.com
Thu Aug 10 16:55:10 UTC 2023


@tomhughes commented on this pull request.

I don't have a problem with this in principle - the existing highlight is so subtle as to be virtually invisible!

The problem is that this is dark enough to make the dividing line between comments card to see when there are two adjacent comments marked as active so I think we need to tweak those lines or something.

I'm not 100% sure bootstrap really intended his class to be used in this way - the intention might be to only highlight row/column/cell at a time with this class?



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4150#pullrequestreview-1572344295
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4150/review/1572344295 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230810/c04e1e8d/attachment.htm>


More information about the rails-dev mailing list