[openstreetmap/openstreetmap-website] Remove most of custom css in message inbox/outbox tables (PR #4155)
Anton Khorev
notifications at github.com
Fri Aug 11 18:29:47 UTC 2023
- `width: 1%;` wasn't working correctly because `.inbox-delete` no longer existsted after rename in https://github.com/openstreetmap/openstreetmap-website/commit/73df8447e3918f08156dd69ddf631652d048f191
- Instead of showing/hiding cells with buttons I show/hide their wrapping forms.
- Many class names had `inbox` in them even if they were used in outbox. `.inbox-row-*` is still kept because it is used in tests and sets row colors which I don't want to change yet.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4155
-- Commit Summary --
* Put message read/unread/delete buttons in one column
* Use Bootstrap nowrap class in messages table
* Refactor message mark/delete listeners
* Change mark message buttons visibility with hidden attr
* Remove unused inbox css classes
* Use flex for buttons cell in messages table
* Center messages table cells vertically
-- File Changes --
M app/assets/javascripts/messages.js (36)
M app/assets/stylesheets/common.scss (23)
M app/views/messages/_message_summary.html.erb (14)
M app/views/messages/_sent_message_summary.html.erb (10)
M app/views/messages/inbox.html.erb (4)
M app/views/messages/outbox.html.erb (3)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4155.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4155.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4155
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4155 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230811/d43ca3dc/attachment-0001.htm>
More information about the rails-dev
mailing list