[openstreetmap/openstreetmap-website] Delete button in Home location section of user profiles (PR #4149)

Andy Allan notifications at github.com
Mon Aug 14 10:37:06 UTC 2023


The ruby style guide recommends against using auxiliary verbs in boolean methods:

https://rubystyle.guide/#bool-methods-prefix

So `User.has_home?` should avoid the `has_` prefix. Perhaps `User.home_location?` instead?

(This would have been flagged up by rubocop for any other model, but it's currently disabled for the User model due to the existing `has_role?` method which has yet to be refactored.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4149#issuecomment-1677084357
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4149/c1677084357 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230814/88fd281b/attachment-0001.htm>


More information about the rails-dev mailing list