[openstreetmap/openstreetmap-website] Upgrade to bootstrap 5.2 (PR #4099)

Andy Allan notifications at github.com
Mon Aug 14 10:55:49 UTC 2023


` bundle exec rails assets:precompile` failed in the CI tests, and I could recreate that locally too. I think I had to clear my local cache to trigger it though.

The error message is the same as previously, namely:

```
SassC::SyntaxError: Error: Custom property values may not be empty.
        on line 1:69677 of stdin
>> t-size:1.25rem;--bs-navbar-toggler-icon-bg:url("data:image/svg+xml,%3csvg xm
```

This indicates that libsass is trying to parse it's own compressed output, which hits a bug in libsass. This is what #4088 was trying to fix - it avoided the reparsing for the main stylesheet by doing everything in one pass, and so it now works for development and testing (when running the tests without precompiling). 

I haven't figured out why the precompile step trips up, but I suspect it's something to do with merging even more stylesheets together (e.g. the leaflet or iD stylesheets or something like that) which triggers reparsing our main stylesheet.

https://github.com/gravitystorm/openstreetmap-website/issues/268 has some more details about all the different libsass vs sassc-rails vs dartsass etc - to help keep it straight in my own head!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4099#issuecomment-1677107302
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4099/c1677107302 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230814/a1d7d838/attachment-0001.htm>


More information about the rails-dev mailing list