[openstreetmap/openstreetmap-website] Use omniauth-microsoft_graph instead of omniauth-windowslive (PR #4169)

[Milan Cvetkovic]

Omniauth-microsoft_graph correctly populates 'email' and 'name' fields used by OpenStreetMap. It also  uses updated endpoints for Microsoft identity provider.

Use email address returned by microsoft_graph provider as a verified address.

Upgrading exisiting users from windowslive to microsoft_graph:
 - upon next login all users will have to authorize OpenStreetMap application to "Read Your Profile," required for proper reading of display name field.

The name of the identity provider in OSM is kept to 'windowslive':
 - the entries in users table with `provider == 'windowslive'` can be reused for microsoft_graph provider, since the uid field is preserved. Users will not need to repeat the sign up process.
 - OAuth2 callback is still `/auth/windowslive`, no updates to Microsoft Identity Provider portal App registration are necessary.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4169

-- Commit Summary --

  * Use omniauth-microsoft_graph instead of omniauth-windowslive

-- File Changes --

    M Gemfile (2)
    M Gemfile.lock (8)
    M app/controllers/users_controller.rb (2)
    M app/views/sessions/new.html.erb (2)
    M config/initializers/omniauth.rb (4)
    M config/settings.yml (4)
    M config/settings/test.yml (4)
    M lib/auth.rb (2)
    M test/integration/user_creation_test.rb (6)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4169.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4169.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4169
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4169 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230814/b343c0df/attachment-0001.htm>