[openstreetmap/openstreetmap-website] Fix predicate method names in the user model (PR #4172)

[Tom Hughes]

This renames the two `has_xxx?` predicate methods in the user model and enables the rubocop warning that catches them.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4172

-- Commit Summary --

  * Fix predicate method names in the user model

-- File Changes --

    M .rubocop_todo.yml (10)
    M app/controllers/diary_entries_controller.rb (2)
    M app/controllers/issue_comments_controller.rb (2)
    M app/controllers/user_roles_controller.rb (4)
    M app/helpers/application_helper.rb (2)
    M app/helpers/user_roles_helper.rb (4)
    M app/models/user.rb (12)
    M app/views/api/users/_user.json.jbuilder (2)
    M app/views/api/users/_user.xml.builder (2)
    M app/views/dashboards/_contact.html.erb (2)
    M app/views/dashboards/show.html.erb (2)
    M app/views/layouts/map.html.erb (2)
    M app/views/profiles/edit.html.erb (8)
    M test/models/user_test.rb (10)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4172.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4172.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4172
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4172 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230815/d5fde3e4/attachment.htm>