[openstreetmap/openstreetmap-website] Change query limit settings format to nested mappings (PR #4189)

Anton Khorev notifications at github.com
Sat Aug 19 16:22:49 UTC 2023


Instead of settings named like this `Settings.max_changeset_query_limit`
it will be easier to work with `Settings.changesets.max_query_limit`.

It matches the api capabilities response structure better.
It will be easier to create a generic [`result_limit` method](https://github.com/openstreetmap/openstreetmap-website/blob/406d90c5c8da5633324bb1d28d7a2103a61c95e4/app/controllers/api/changesets_controller.rb#L426).

Also added settings validation in `config/initializers/config.rb`.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4189

-- Commit Summary --

  * Change query limit settings format to nested mappings

-- File Changes --

    M app/controllers/api/changesets_controller.rb (6)
    M app/controllers/api/notes_controller.rb (6)
    M app/views/api/capabilities/show.builder (8)
    M app/views/api/capabilities/show.json.jbuilder (8)
    M config/initializers/config.rb (8)
    M config/settings.yml (18)
    M test/controllers/api/capabilities_controller_test.rb (16)
    M test/controllers/api/changesets_controller_test.rb (15)
    M test/controllers/api/notes_controller_test.rb (20)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4189.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4189.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4189
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4189 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230819/6f9db9e1/attachment.htm>


More information about the rails-dev mailing list