[openstreetmap/openstreetmap-website] Create a base user resources controller class (PR #4197)

[Andy Allan]

Thanks for the PR, but I'm against this approach. These controllers are not conceptually subclasses of one "user-related" class. That's using one mechanism (inheritance) to implement what is, at best, a couple of helper methods. It will also entirely break down if you have another non-user-related method that you want to share between controllers!

I would suggest looking into "concerns", or other similar mixin methods, rather than using class inheritance.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4197#issuecomment-1686380699
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4197/c1686380699 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230821/cfc506b1/attachment.htm>