[openstreetmap/openstreetmap-website] Use where instead of find to prevent 404 (b9c85c2)
Andy Allan
notifications at github.com
Tue Aug 29 10:27:35 UTC 2023
There's a lot here in this conversation, so I'll be brief:
* Ideally when the backwards-incompatible changes were made, and were found to break someone's application, they should have been reverted immediately and then the options discussed. However, I'm not involved in the time-sensitive tasks that OWG and DWG have been involved in over the last few days, so I can't judge whether this breakage was worthwhile for other reasons.
* Ideally the backwards-incompatible changes should have been highlighted in the PR and at review time, so that they could be investigated (e.g. using server logs) and discussed before merging.
* The topics of how to handle backward-incompatible changes, running multiple versions of the API, etc are all dear to my heart, but far to substantial to be discussed in a commit comment!
* If you are surprised by the lack of formal documentation covering all edge cases of every API, then you'll be shocked when you find out how few volunteers contribute to the codebase. It's not "a significant oversight", it's a balance of priorities under extremely tight resource constraints. I'd love to have 1000 other things improved too!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/commit/b9c85c269726faad3c2613b37f01683c8b59f5c6#commitcomment-125803427
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/commit/b9c85c269726faad3c2613b37f01683c8b59f5c6/125803427 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230829/f1dde31b/attachment.htm>
More information about the rails-dev
mailing list