[openstreetmap/openstreetmap-website] Address review comments for changeset comment limiting (PR #4211)

[Tom Hughes]

This aims to address the review comments from #4202 which was already merged.

It mostly makes the request changes - one different is that I went with `initial` rather than `default` as the new name for the starting limit as default seemed confusing when it's only the default for a new user.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4211

-- Commit Summary --

  * Improve naming of changeset comment rate limit settings
  * Move changeset comment rate limit check to a predicate method
  * Improve testing of changeset comment rate limits

-- File Changes --

    M app/controllers/api/changeset_comments_controller.rb (12)
    M app/models/user.rb (6)
    M config/settings.yml (4)
    M config/settings/test.yml (3)
    M test/controllers/api/changeset_comments_controller_test.rb (73)
    M test/factories/issues.rb (11)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4211.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4211.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4211
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4211 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230830/2b82f2b7/attachment.htm>