[openstreetmap/openstreetmap-website] Remove unused .current from primary nav (PR #4389)

Anton Khorev notifications at github.com
Mon Dec 4 02:20:51 UTC 2023


There's this `current_page_class()` function that applies `current` css class to header menu items pointing to the current page. [This commit](https://github.com/openstreetmap/openstreetmap-website/commit/e5c33c119a9ddd4de149cd8913ed970601103a2b#diff-6d2ef58207c92d1533287af551a075122ba98240a861819047a2ae77b7674f0bR33-R34) broke it for primary nav buttons, but nobody noticed because the `current` class is not used for anything. Still the javascript applied it correctly on partial page reloads.

Here I remove `current` from primary navigation.

It's still used in secondary navigation, makes current links darker.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4389

-- Commit Summary --

  * Remove unused .current from primary nav

-- File Changes --

    M app/assets/javascripts/index/export.js (3)
    M app/assets/javascripts/index/history.js (3)
    M app/views/layouts/_header.html.erb (6)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4389.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4389.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4389
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4389 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231203/3e5e6096/attachment.htm>


More information about the rails-dev mailing list