[openstreetmap/openstreetmap-website] Align structure with generated output (PR #4390)
Andy Allan
notifications at github.com
Wed Dec 6 14:40:32 UTC 2023
This PR makes a minor change to the structure.sql file to align it with the output from running migrations, along with some changes to the normalisation script. These normalisations can be removed since they aren't actually doing anything in CI.
* Adds the btree_gist comment. All developers will have this in their generated output from running the migrations so we should have it here too, to avoid noise in `git diff` (and therefore to make it easier to submit PRs with migrations).
* Remove the timestamp normalisation - see https://github.com/openstreetmap/openstreetmap-website/issues/4298#issuecomment-1832194246 on how to update really old pre-rails-6 databases, if you have one.
* Remove sequence type normalisation - this is actually important, and [differences shouldn't be suppressed](https://github.com/openstreetmap/openstreetmap-website/issues/4298#issuecomment-1832615439)
* Remove references to plpgsql extension, since it's been built-in since PostgreSQL 9.0
* Remove normalisation of immutable keyword, since we no longer have any functions that use it.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4390
-- Commit Summary --
* Add comment for btree_gist to structure.sql
* Remove the timestamp normalisation
* Remove the sequence type normalisation
* Remove the references to plpgsql extension
* Remove normalisation of immutable keyword
-- File Changes --
M db/structure.sql (7)
M script/normalise-structure (8)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4390.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4390.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4390
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4390 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231206/eb9cb2cb/attachment.htm>
More information about the rails-dev
mailing list