[openstreetmap/openstreetmap-website] Add some javascript to check dynamically if the username is already taken (PR #4402)

Anton Khorev notifications at github.com
Wed Dec 13 14:04:39 UTC 2023


@AntonKhorev commented on this pull request.



> @@ -223,4 +223,62 @@ $(document).ready(function () {
   $("#read_tou").on("click", function () {
     $("#continue").prop("disabled", !($(this).prop("checked") && $("#read_ct").prop("checked")));
   });
+
+
+  const isTaken /* Record<string, string> */ = {}
+
+  function indicateInvalidDisplayName(isValid /* boolean | undefined*/) {

The function name is confusing. It indicates valid names too, and the argument is `isValid`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4402#pullrequestreview-1779715840
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4402/review/1779715840 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231213/cb9f67c8/attachment.htm>


More information about the rails-dev mailing list