[openstreetmap/openstreetmap-website] Use inline svgs in map key (PR #4421)

Anton Khorev notifications at github.com
Tue Dec 19 14:08:05 UTC 2023


Instead of [optimizing svg data uris](#4419) we can use inline svgs here.

Now this:

    <img src="data:image/svg+xml,%3Csvg%20xmlns%3D%27http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%27%20width%3D%2752%27%20height%3D%271%27%3E%3Crect%20width%3D%27100%25%27%20height%3D%27100%25%27%20fill%3D%27%23787878%27%20%2F%3E%3C%2Fsvg%3E" />

becomes this:

    <svg width="52" height="1" class="d-block mx-auto"><rect width="100%" height="100%" fill="#787878" /></svg>

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4421

-- Commit Summary --

  * Remove map key image custom css
  * Add solid svg image helper
  * Use inline svg for solid map key images

-- File Changes --

    M app/assets/stylesheets/common.scss (10)
    A app/helpers/svg_helper.rb (7)
    M app/views/site/key.html.erb (10)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4421.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4421.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4421
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4421 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231219/ab22c75a/attachment.htm>


More information about the rails-dev mailing list