[openstreetmap/openstreetmap-website] Add login notice for note discussions (PR #4449)

Anton Khorev notifications at github.com
Sun Dec 31 02:23:59 UTC 2023


Add "Log in to comment on this note" link as requested in the [original post](https://github.com/openstreetmap/openstreetmap-website/issues/2761#issue-675527428) in https://github.com/openstreetmap/openstreetmap-website/issues/2761.

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/935d29eb-1b6b-4d9c-bd16-abd095073a8f)

There also was [another request](https://github.com/openstreetmap/openstreetmap-website/issues/2761#issuecomment-1225816994) which I **didn't do**: adding "Log in to resolve/reactivate". Some users close and reopen notes several times for no apparent reason and previously we added texts to discourage that. I don't want to write anything that will encourage these actions.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4449

-- Commit Summary --

  * Add login notice for note discussions

-- File Changes --

    M app/views/notes/show.html.erb (4)
    M config/locales/en.yml (1)
    M test/system/note_comments_test.rb (17)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4449.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4449.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4449
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4449 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231230/019027da/attachment-0001.htm>


More information about the rails-dev mailing list