[openstreetmap/openstreetmap-website] Vel-12/issue#3910 Resolved (PR #3922)

[Andy Allan]

@vel-12 this PR contains two commits, the second commit is fixing a mistake that you made in the first commit.

>From [CONTRIBUTING.md](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md)

> The commit history is important. This is a large codebase, developed over many years by many developers. We frequently need to read the commit history (e.g. using git blame) to figure out what is going on. So small, understandable, and relevant commits are important for other developers looking back at your work in future.

> Avoid including "fixup" commits. If you have added a fixup commit (for example to fix a rubocop warning, or because you changed your own new code) please combine the fixup commit into the commit that introduced the problem. git rebase -i is very useful for this.

I would also like to see more of an explanation in your pull request, to show that by changing the direction of form controls that you aren't introducing any side effects. See also the continuing discussion at #3910.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3922#issuecomment-1424014123
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3922/c1424014123 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230209/b25b18c7/attachment.htm>