[openstreetmap/openstreetmap-website] Facelift `offline.html` and use Bootstrap classes for "notifications" under the search bar (PR #3907)

Andy Allan notifications at github.com
Thu Feb 9 11:12:22 UTC 2023


@gravitystorm commented on this pull request.



> @@ -1,7 +1,9 @@
+<div class="alert alert-danger text-center">

Keep the test, it's still required. The final assertion no longer makes sense and needs to be adjusted - I would change it to no longer asserting that a particular template is used (since we aren't using a view), but to change it to ensure that the layout is still rendered, since we need the layout to make sure the flash message is displayed. 

There are examples of asserting the layout elsewhere in the test directory.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3907#discussion_r1101315474
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3907/review/1290916844 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230209/12408bcf/attachment.htm>


More information about the rails-dev mailing list