[openstreetmap/openstreetmap-website] Avoid using html in translations (PR #3936)
Tom Hughes
notifications at github.com
Wed Feb 22 09:53:13 UTC 2023
@tomhughes commented on this pull request.
So a lot of the translations that no longer have HTML in still have an `_html` suffix which I guess is necessary because we substituting HTML into them via variables?
> @@ -0,0 +1,14 @@
+<hr class="mb-3" />
+<a name="public"></a>
+<h2><%= t ".heading" %></h2>
+<p>
+ <%= t ".currently_not_public" %>
+ <strong><%= t ".only_public_can_edit" %></strong>
+ <%= t ".find_out_why_html", :link => link_to(t(".find_out_why"),
+ t(".find_out_why_url")) %>
Is this a bit too close to being lego? Are we sure splitting the sentence into pieces like this is going to be OK in all translations?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3936#pullrequestreview-1308881993
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3936/review/1308881993 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230222/d6cf733f/attachment.htm>
More information about the rails-dev
mailing list