[openstreetmap/openstreetmap-website] bundle exec eslint error (Issue #3946)

[Andy Allan]

> Works fine for me - must be a docker issue.

No, it's not a Docker issue. I mentioned this previously in the final paragraph [of this comment](https://github.com/openstreetmap/openstreetmap-website/issues/3579#issuecomment-1371453162) - the version of eslint that we use requires nodejs 12+, but Ubuntu 20.04 ships with node 10. We tend not to notice since most developers (including me) don't run node10 on our laptops. Github CI uses their own "flavour" of Ubuntu, with a newer nodejs version, so it's not picked up in the [eslint CI task](https://github.com/openstreetmap/openstreetmap-website/blob/87657108f6bd2a4afa41760dff1947a8349b28f8/.github/workflows/lint.yml#L38). If CI was running actual Ubuntu, with nodejs10, then it would have picked up this problem months ago and the eslint test would fail with the same error.

The preferred fix is the same as I wrote in that comment - we need to upgrade our Docker, Vagrant, CI and installation instructions all to Ubuntu 22.04.

If we wanted to prevent this from happening again, we need to rethink our CI system, so that it runs eslint (and rubocop, and other developer tools) on the actual version of Ubuntu that developers have installed, rather than the github-flavoured-ubuntu used in Github Actions. One way to do this would be to add eslint to the [docker CI](https://github.com/openstreetmap/openstreetmap-website/blob/master/.github/workflows/docker.yml), but I'd prefer to avoid making that even slower to run. I don't intend to work on this aspect though, since upgrading everything to 22.04 is needed anyway. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3946#issuecomment-1445309595
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/3946/1445309595 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230226/a159e000/attachment.htm>