[openstreetmap/openstreetmap-website] fix formatting of tag values with semicolon-separated URLs (PR #3868)

Kyℓe Hensel notifications at github.com
Sun Jan 1 02:45:17 UTC 2023


If a tag value currently contains two URLs separated by a semicolon, the website creates a broken clickable link. 

[This example node](https://osm.org/node/9335292678) can be viewed on osm.org and in the Washington, D.C. example from [the installation guide](https://github.com/openstreetmap/openstreetmap-website/blob/master/DOCKER.md#loading-an-osm-extract).

<table>
<tr>
<td><strong>Before
<td><strong>After
<tr>
<td><img src="https://user-images.githubusercontent.com/16009897/210159559-222dab8d-6562-4e5b-9471-1ed0123ced86.jpg" />
<td><img src="https://user-images.githubusercontent.com/16009897/210159568-b5d9a27c-e801-4c46-afa5-f6afe3acd213.jpg" />
</table>

Closes openstreetmap/iD#9444 which was opened in the wrong issue tracker.


p.s. Please reconsider merging #3575, it's impossible for first time contributors to run the tests without digging through the issue tracker to find that rejected PR. 
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3868

-- Commit Summary --

  * fix formatting of tag values with semicolon-separated URLs

-- File Changes --

    M app/helpers/browse_tags_helper.rb (2)
    M test/helpers/browse_tags_helper_test.rb (6)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3868.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3868.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3868
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3868 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221231/b0f96ec6/attachment.htm>


More information about the rails-dev mailing list