[openstreetmap/openstreetmap-website] Allow models to load when the database is offline (PR #3874)
Andy Allan
notifications at github.com
Fri Jan 6 13:10:32 UTC 2023
@gravitystorm approved this pull request.
Looks good to me! In fact, it looks excellent.
One of my major concerns with how to test offline/readonly mode functionality has been around booting the app into the different modes, or somehow unloading ActiveRecord while running the offline mode tests. But with this change, there's no difference in the booting or the class loading, and so we can write accurate tests much, much more easily.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3874#pullrequestreview-1238817928
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3874/review/1238817928 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230106/be8d0db1/attachment.htm>
More information about the rails-dev
mailing list