[openstreetmap/openstreetmap-website] Use bin/yarn consistently for installations (PR #3890)

[Andy Allan]

Since rails 7, the `rails yarn:install` command no longer uses bin/yarn and so it
- doesn't detect yarn binaries named "yarnpkg" (e.g. Ubuntu), and
- doesn't allow us to pass any flags to yarn, (e.g. "--ignore-engines").

Since we want to avoid making the installation more difficult (by e.g. installing yarn from other sources, or requiring particular node versions) we can instead just use our existing bin/yarn script.

The reason Dockerfile did its own thing was to avoid pulling in big chunks of rails, but bin/yarn is a standalone ruby script.

Fixes #3579
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3890

-- Commit Summary --

  * Use bin/yarn consistently for installations

-- File Changes --

    M .github/workflows/lint.yml (2)
    M .github/workflows/tests.yml (2)
    M Dockerfile (6)
    M INSTALL.md (2)
    M script/vagrant/setup/provision.sh (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3890.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3890.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3890
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3890 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230111/3dd7e7d2/attachment.htm>