[openstreetmap/openstreetmap-website] Add a "copy coordinates" entry to the right click menu (PR #3903)
Andy Allan
notifications at github.com
Wed Jan 25 12:01:24 UTC 2023
I've spent far too much time thinking about this, considering the lack of obvious mapper-related use cases! In all my years mapping for OSM I've never needed to copy coordinates while browsing the map, and the original issue gives no indication how this feature would help mappers or fits into any mapping workflow either.
>From a technical point of view it's mostly fine, but it reopens the can of worms that is coordinate formatting. I worry that merging this PR as-is might then lead to a succession of debates, hassle and/or followup PRs because:
* The coordinate formatting in this PR doesn't match the rest of the site. JavaScript `toFixed` is not locale-aware, so many users will get decimal points in the clipboard instead of the decimal commas that we show elsewhere. While I don't have a strong view as to which is right, it would be nice to be consistent. See also #2732
* The coordinate delineator is not translatable. See #2783
In saying all that, I don't feel particularly strongly for any of the three outcomes - either to merge as-is, make the PR more complex for a not-important cause, or leave the feature off entirely.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3903#issuecomment-1403500956
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3903/c1403500956 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230125/85e87e04/attachment.htm>
More information about the rails-dev
mailing list